https://bugzilla.redhat.com/show_bug.cgi?id=834582
--- Comment #3 from Mikolaj Izdebski <mizde...@redhat.com> --- (In reply to comment #2) > 1. Changelog entry version is incorrect > java-deptools.noarch: W: incoherent-version-in-changelog > 0-0.1.20120621git20120621 ['0-0.1.20120621git2a6a72d.fc18', > '0-0.1.20120621git2a6a72d'] Corrected: Spec URL: http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.2.20120621git2a6a72d.spec SRPM URL: http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.2.20120621git2a6a72d.fc16.src.rpm > 2. specfile name should be java-deptools.spec > [!]: MUST Spec file name must match the spec package %{name}, in the format > %{name}.spec. It really *IS* named %{name}.spec. You can extract the SRPM and you'll see it is named "java-deptools.spec". Only the name in the URL used only for this review is different. > 3. Line 60 of specfile should have 'cp -pR' instead of 'cp -R' > [!]: SHOULD Packages should try to preserve timestamps of original installed > files. Guidelines says that "original files" should have their timestamps preserved, but files in "target/site/apidocs" are NOT original files -- they are being generated during build time. Their times are set during the build time and preserving them makes no sense. The only original file, pom.xml, does have its timestamp preserved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
