https://bugzilla.redhat.com/show_bug.cgi?id=853784
--- Comment #3 from Martin Gieseking <martin.giesek...@uos.de> --- (In reply to comment #2) > Ok i dropped the devel package though i will need to reintroduce it for the > next release because it will contain the currently missing headers. OK, that's fine. Some additional remarks: - Unlike mentioned in your spec, libtiled is not licensed under BSD at the moment. According to the boilerplates of maprenderer.cpp, gidmapper.cpp, and gidmapper.h, these files are GPLv2+. This is probably a mistake. Please ask upstream for clarification. Currently, BSD- and GPLv2+-licensed code is linked together, and the resulting binary must be licensed under GPLv2+ as the latter it more restrictive than BSD. - Preserve the timestamps by adding -p to the 3rd and 4th "install" statement. - In the first two "install" statements, change the file permissions 664 to 644. Sorry, the 664 was a typo in one of my comments about your mana package and should be fixed there as well. ;) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
