Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907036
Petr Pisar <ppi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #4 from Petr Pisar <ppi...@redhat.com> ---
Spec file changes:
[test@fedora-19 SPECS]$ diff -u perl-Math-PlanePath.spec{.old,}
--- perl-Math-PlanePath.spec.old 2013-02-06 11:06:39.178000000 +0100
+++ perl-Math-PlanePath.spec 2013-02-11 09:54:36.950000000 +0100
@@ -1,21 +1,29 @@
Name: perl-Math-PlanePath
Version: 98
-Release: 1%{?dist}
-Summary: Points on a path through the 2D plane
+Release: 2%{?dist}
+Summary: Mathematical paths through the 2-D plane
License: GPLv3+
Group: Development/Libraries
-URL: http://search.cpan.org/dist/Math-PlanePath/
+URL: http://user42.tuxfamily.org/math-planepath/index.html
Source0:
http://www.cpan.org/authors/id/K/KR/KRYDE/Math-PlanePath-%{version}.tar.gz
BuildArch: noarch
-BuildRequires: perl >= 0:5.004
+BuildRequires: perl(Carp)
+BuildRequires: perl(constant) >= 1.02
BuildRequires: perl(constant::defer) >= 5
+BuildRequires: perl(Exporter)
BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(lib)
BuildRequires: perl(List::Util)
-BuildRequires: perl(Math::BigFloat)
+BuildRequires: perl(Math::BigFloat) >= 1.993
BuildRequires: perl(Math::BigInt)
-BuildRequires: perl(Math::BigRat)
BuildRequires: perl(Math::Libm)
+BuildRequires: perl(Scalar::Util)
+BuildRequires: perl(Test)
Requires: perl(constant::defer) >= 5
+Requires: perl(Math::Factor::XS)
+Requires: perl(Math::NumSeq::Modulo)
+Requires: perl(Module::Load)
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
# Filtering unversioned provides and requires
@@ -24,8 +32,8 @@
%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}^perl\\(constant\\)$
%description
-This is a base class for some mathematical paths which map an integer
-position $n to and from coordinates $x,$y in the 2D plane.
+This spot of Perl code calculates various mathematical paths through a 2-D X,Y
+plane. There's no drawing in Math-PlanePath, just coordinate calculations.
%prep
%setup -q -n Math-PlanePath-%{version}
@@ -46,11 +54,29 @@
make test
%files
-%doc Changes COPYING
+%doc Changes COPYING debian/copyright
%{perl_vendorlib}/Math*
%{_mandir}/man3/*
%changelog
+* Sat Feb 09 2013 Miro Hrončok <mhron...@redhat.com> - 98-2
+- Using original homepage for URL
+- Updated summary and description to suit whole package
+- Packaged debian/copyright as documentation
+- Quallified BR perl(Math::BigFloat) with >= 1.993
+- Build-required perl(constant) >= 1.02
+ perl(Test)
+ perl(Scalar::Util)
+ perl(Carp)
+ perl(File::Spec)
+ perl(Exporter)
+ perl(lib)
+- Run-required perl(Math::Factor::XS)
+ perl(Math::NumSeq::Modulo)
+ perl(Module::Load)
+- Removed BR perl(Math::BigRat)
+ perl >= 0:5.004
+
* Sat Feb 02 2013 Miro Hrončok <mhron...@redhat.com> - 98-1
- New release
- Removed perl default filter
> FIX: Use original homepage for URL
> <http://user42.tuxfamily.org/math-planepath/index.html> (debian/copyright:9).
-URL: http://search.cpan.org/dist/Math-PlanePath/
+URL: http://user42.tuxfamily.org/math-planepath/index.html
Ok.
> FIX: Current Summary and Description applies to Math::PlanePath module only.
> However this package delivers plenty of other modules. Please use better
> text. E.g. Abstract from from META.yml.
-Summary: Points on a path through the 2D plane
+Summary: Mathematical paths through the 2-D plane
%description
-This is a base class for some mathematical paths which map an integer
-position $n to and from coordinates $x,$y in the 2D plane.
+This spot of Perl code calculates various mathematical paths through a 2-D X,Y
+plane. There's no drawing in Math-PlanePath, just coordinate calculations.
Ok.
> TODO: You can remove build-require `perl >= 0:5.004'. It does not match
> Fedora versioning.
-BuildRequires: perl >= 0:5.004
Ok.
> TODO: Package debian/copyright as documentation.
-%doc Changes COPYING
+%doc Changes COPYING debian/copyright
Ok.
> TODO: (Build-)require `perl(constant) >= 1.02' (META.yml:14, various lib/*
> files).
+BuildRequires: perl(constant) >= 1.02
TODO: Run-require `perl(constant) >= 1.02' due to the version.
> TODO: Build-require `perl(Test)' (t/DiagonalRationals.t:22).
+BuildRequires: perl(Test)
Ok.
> TODO: Quallify BuildRequires `perl(Math::BigFloat)' with `>= 1.993'
> (META.yml:44).
-BuildRequires: perl(Math::BigFloat)
+BuildRequires: perl(Math::BigFloat) >= 1.993
Ok.
> FIX: Build-require `perl(Scalar::Util)' (t/MyTestHelpers.pm:102).
+BuildRequires: perl(Scalar::Util)
Ok.
> TODO: Build-require `perl(Exporter)' (lib/Math/PlanePath/Base/Generic.pm:26).
+BuildRequires: perl(Exporter)
Ok.
> TODO: Build-require`perl(lib)' (t/DiagonalRationals.t:25).
+BuildRequires: perl(lib)
Ok.
> TODO: I recommend to build-require available optional modules to proceed more
> tests and to put unavailable ones into comments to enable them later.
Not addressed.
> FIX: Remove unused `perl(Math::BigRat)' build-requirement.
-BuildRequires: perl(Math::BigRat)
Ok.
> FIX: Run-require `perl(Math::NumSeq::Modulo)'
> (lib/Math/NumSeq/PlanePathCoord.pm:244).
+Requires: perl(Math::NumSeq::Modulo)
Ok.
> FIX: Run-require `perl(Module::Load)' (lib/Math/NumSeq/PlanePathCoord.pm:328).
+Requires: perl(Module::Load)
Ok.
> FIX: Run-require `perl(Math::Factor::XS)
> (lib/Math/NumSeq/PlanePathCoord.pm:880).
+Requires: perl(Math::Factor::XS)
Ok.
All tests pass. Ok.
$ rpmlint perl-Math-PlanePath.spec
../SRPMS/perl-Math-PlanePath-98-2.fc19.src.rpm
../RPMS/noarch/perl-Math-PlanePath-98-2.fc19.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Math-PlanePath-98-2.fc19.noarch.rpm
| sort | uniq -c 1 perl >=
0:5.004
1 perl(Carp)
1 perl(constant) >= 1.02
1 perl(constant::defer) >= 5
1 perl(Exporter)
1 perl(List::Util)
1 perl(Math::Factor::XS)
1 perl(Math::Libm)
1 perl(Math::NumSeq)
1 perl(Math::NumSeq::Base::IterateIth)
1 perl(Math::NumSeq::Modulo)
1 perl(Math::NumSeq::OEIS::Catalogue::Plugin)
1 perl(Math::NumSeq::PlanePathCoord)
1 perl(Math::PlanePath)
1 perl(Math::PlanePath::AlternatePaper)
1 perl(Math::PlanePath::Base::Digits)
1 perl(Math::PlanePath::Base::Generic)
1 perl(Math::PlanePath::BetaOmega) >= 52
1 perl(Math::PlanePath::CellularRule54)
1 perl(Math::PlanePath::CoprimeColumns)
1 perl(Math::PlanePath::DekkingCentres)
1 perl(Math::PlanePath::DiagonalRationals)
1 perl(Math::PlanePath::Diagonals)
1 perl(Math::PlanePath::DragonCurve)
1 perl(Math::PlanePath::DragonMidpoint)
1 perl(Math::PlanePath::FlowsnakeCentres) >= 55
1 perl(Math::PlanePath::GcdRationals)
1 perl(Math::PlanePath::GosperIslands)
1 perl(Math::PlanePath::ImaginaryBase)
1 perl(Math::PlanePath::KochCurve)
1 perl(Math::PlanePath::MultipleRings)
1 perl(Math::PlanePath::PeanoCurve)
1 perl(Math::PlanePath::PyramidRows)
1 perl(Math::PlanePath::QuadricCurve)
1 perl(Math::PlanePath::QuintetCentres)
1 perl(Math::PlanePath::RationalsTree)
1 perl(Math::PlanePath::SacksSpiral)
1 perl(Math::PlanePath::SierpinskiArrowhead)
1 perl(Math::PlanePath::SierpinskiCurve)
1 perl(Math::PlanePath::SquareArms)
1 perl(Math::PlanePath::SquareSpiral)
1 perl(Math::PlanePath::TerdragonCurve)
1 perl(Math::PlanePath::TerdragonMidpoint)
1 perl(Math::PlanePath::UlamWarburtonQuarter)
1 perl(Math::PlanePath::ZOrderCurve)
1 perl(:MODULE_COMPAT_5.16.2)
1 perl(Module::Load)
1 perl(POSIX)
1 perl(strict)
1 perl(vars)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
Package builds in F19
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4949147). Ok.
Package is good.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cznGdZ7x3u&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
