Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905255
--- Comment #72 from Simone Caronni <negativ...@gmail.com> ---
Package Review
==============
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in open-vm-
tools-desktop , open-vm-tools-devel
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL", "CDDL", "LGPL", "CDDL BSD (3 clause) LGPL", "Unknown or
generated", "BSD (3 clause) GPL", "MIT/X11 (BSD like)", "ISC", "CDDL
LGPL", "CDDL GPL", "BSD (3 clause)", "GPL (v2 or later)", "GPL (v2)". 13
files have unknown license. Detailed output of licensecheck in
/home/slaanesh/Documents/fedora/905255-open-vm-tools/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
===== SHOULD items =====
Generic:
[!]: Spec use %global instead of %define.
Note: %define majorversion 9.2 %define minorversion 2 %define toolsbuild
893683 %define toolsversion %{majorversion}.%{minorversion} %define
toolsdaemon vmtoolsd
[x]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Arch-ed rpms have a total of 1372160 bytes in /usr/share 1116160
open-vm-tools-devel-9.2.2-9.fc18.x86_64.rpm 256000 open-vm-
tools-9.2.2-9.fc18.x86_64.rpm
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: open-vm-tools-9.2.2-9.fc18.x86_64.rpm
open-vm-tools-desktop-9.2.2-9.fc18.x86_64.rpm
open-vm-tools-devel-9.2.2-9.fc18.x86_64.rpm
open-vm-tools.x86_64: W: spelling-error %description -l en_US virtualization ->
visualization, actualization, vitalization
open-vm-tools.x86_64: E: postin-without-ldconfig /usr/lib64/libvmtools.so.0.0.0
open-vm-tools.x86_64: E: postun-without-ldconfig /usr/lib64/libvmtools.so.0.0.0
open-vm-tools.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/open-vm-tools-9.2.2/README
open-vm-tools.x86_64: E: postin-without-ldconfig
/usr/lib64/libguestlib.so.0.0.0
open-vm-tools.x86_64: E: postun-without-ldconfig
/usr/lib64/libguestlib.so.0.0.0
open-vm-tools.x86_64: E: executable-marked-as-config-file /etc/pam.d/vmtoolsd
open-vm-tools.x86_64: E: script-without-shebang /etc/pam.d/vmtoolsd
open-vm-tools.x86_64: E: postin-without-ldconfig /usr/lib64/libhgfs.so.0.0.0
open-vm-tools.x86_64: E: postun-without-ldconfig /usr/lib64/libhgfs.so.0.0.0
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-xferlogs
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-checkvm
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-toolbox-cmd
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-hgfsclient
open-vm-tools.x86_64: W: no-manual-page-for-binary vmtoolsd
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-rpctool
open-vm-tools.x86_64: W: no-manual-page-for-binary mount.vmhgfs
open-vm-tools.x86_64: W: install-file-in-docs
/usr/share/doc/open-vm-tools-9.2.2/INSTALL
open-vm-tools-desktop.x86_64: E: summary-too-long C User experience components
for Open VMware Tools for virtual machines hosted on VMware
open-vm-tools-desktop.x86_64: W: no-documentation
open-vm-tools-desktop.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/vmware-user.desktop
open-vm-tools-desktop.x86_64: W: no-manual-page-for-binary vmware-vmblock-fuse
open-vm-tools-desktop.x86_64: W: no-manual-page-for-binary
vmware-user-suid-wrapper
3 packages and 0 specfiles checked; 9 errors, 14 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint open-vm-tools open-vm-tools-devel open-vm-tools-desktop
open-vm-tools.x86_64: W: spelling-error %description -l en_US virtualization ->
visualization, actualization, vitalization
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libvmtools.so.0.0.0 /lib64/libcrypt.so.1
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libvmtools.so.0.0.0 /lib64/libicudata.so.49
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libvmtools.so.0.0.0 /lib64/libm.so.6
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/librt.so.1
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/libcrypt.so.1
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/libicui18n.so.49
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/libicuuc.so.49
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/libicudata.so.49
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/libpthread.so.0
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/libdl.so.2
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/libm.so.6
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libguestlib.so.0.0.0 /lib64/libglib-2.0.so.0
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/libgthread-2.0.so.0
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/librt.so.1
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/libcrypt.so.1
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/libicui18n.so.49
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/libicuuc.so.49
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/libicudata.so.49
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/libdl.so.2
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/libm.so.6
open-vm-tools.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libhgfs.so.0.0.0 /lib64/libglib-2.0.so.0
open-vm-tools.x86_64: E: postin-without-ldconfig /usr/lib64/libvmtools.so.0.0.0
open-vm-tools.x86_64: E: postun-without-ldconfig /usr/lib64/libvmtools.so.0.0.0
open-vm-tools.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/open-vm-tools-9.2.2/README
open-vm-tools.x86_64: E: postin-without-ldconfig
/usr/lib64/libguestlib.so.0.0.0
open-vm-tools.x86_64: E: postun-without-ldconfig
/usr/lib64/libguestlib.so.0.0.0
open-vm-tools.x86_64: E: executable-marked-as-config-file /etc/pam.d/vmtoolsd
open-vm-tools.x86_64: E: script-without-shebang /etc/pam.d/vmtoolsd
open-vm-tools.x86_64: E: postin-without-ldconfig /usr/lib64/libhgfs.so.0.0.0
open-vm-tools.x86_64: E: postun-without-ldconfig /usr/lib64/libhgfs.so.0.0.0
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-xferlogs
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-checkvm
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-toolbox-cmd
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-hgfsclient
open-vm-tools.x86_64: W: no-manual-page-for-binary vmtoolsd
open-vm-tools.x86_64: W: no-manual-page-for-binary vmware-rpctool
open-vm-tools.x86_64: W: no-manual-page-for-binary mount.vmhgfs
open-vm-tools.x86_64: W: install-file-in-docs
/usr/share/doc/open-vm-tools-9.2.2/INSTALL
open-vm-tools-desktop.x86_64: E: summary-too-long C User experience components
for Open VMware Tools for virtual machines hosted on VMware
open-vm-tools-desktop.x86_64: W: no-documentation
open-vm-tools-desktop.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/vmware-user.desktop
open-vm-tools-desktop.x86_64: W: no-manual-page-for-binary vmware-vmblock-fuse
open-vm-tools-desktop.x86_64: W: no-manual-page-for-binary
vmware-user-suid-wrapper
3 packages and 0 specfiles checked; 9 errors, 35 warnings.
# echo 'rpmlint-done:'
Requires
--------
open-vm-tools (rpmlib, GLIBC filtered):
/bin/sh
config(open-vm-tools)
libc.so.6()(64bit)
libcrypt.so.1()(64bit)
libdl.so.2()(64bit)
libdnet.so.1()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3)(64bit)
libglib-2.0.so.0()(64bit)
libgmodule-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libguestlib.so.0()(64bit)
libhgfs.so.0()(64bit)
libicudata.so.49()(64bit)
libicui18n.so.49()(64bit)
libicuuc.so.49()(64bit)
libm.so.6()(64bit)
libprocps.so.0()(64bit)
libprocps.so.0(LIBPROCPS_0)(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libstdc++.so.6()(64bit)
libvmtools.so.0()(64bit)
rtld(GNU_HASH)
systemd
open-vm-tools-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
libguestlib.so.0()(64bit)
libhgfs.so.0()(64bit)
libvmtools.so.0()(64bit)
open-vm-tools
open-vm-tools-desktop (rpmlib, GLIBC filtered):
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libXi.so.6()(64bit)
libXinerama.so.1()(64bit)
libXrandr.so.2()(64bit)
libXrender.so.1()(64bit)
libXtst.so.6()(64bit)
libatk-1.0.so.0()(64bit)
libatkmm-1.6.so.1()(64bit)
libc.so.6()(64bit)
libcairo.so.2()(64bit)
libcairomm-1.0.so.1()(64bit)
libcrypt.so.1()(64bit)
libdl.so.2()(64bit)
libfontconfig.so.1()(64bit)
libfreetype.so.6()(64bit)
libfuse.so.2()(64bit)
libfuse.so.2(FUSE_2.6)(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgdk-x11-2.0.so.0()(64bit)
libgdk_pixbuf-2.0.so.0()(64bit)
libgdkmm-2.4.so.1()(64bit)
libgio-2.0.so.0()(64bit)
libgiomm-2.4.so.1()(64bit)
libglib-2.0.so.0()(64bit)
libglibmm-2.4.so.1()(64bit)
libgobject-2.0.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libgtk-x11-2.0.so.0()(64bit)
libgtkmm-2.4.so.1()(64bit)
libhgfs.so.0()(64bit)
libicudata.so.49()(64bit)
libicui18n.so.49()(64bit)
libicuuc.so.49()(64bit)
libm.so.6()(64bit)
libpango-1.0.so.0()(64bit)
libpangocairo-1.0.so.0()(64bit)
libpangoft2-1.0.so.0()(64bit)
libpangomm-1.4.so.1()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libsigc-2.0.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libvmtools.so.0()(64bit)
open-vm-tools
rtld(GNU_HASH)
Provides
--------
open-vm-tools:
config(open-vm-tools)
libguestInfo.so()(64bit)
libguestlib.so.0()(64bit)
libhgfs.so.0()(64bit)
libhgfsServer.so()(64bit)
libpowerOps.so()(64bit)
libtimeSync.so()(64bit)
libvix.so()(64bit)
libvmbackup.so()(64bit)
libvmtools.so.0()(64bit)
open-vm-tools
open-vm-tools(x86-64)
open-vm-tools-devel:
open-vm-tools-devel
open-vm-tools-devel(x86-64)
pkgconfig(vmguestlib)
open-vm-tools-desktop:
libdesktopEvents.so()(64bit)
libdndcp.so()(64bit)
libresolutionSet.so()(64bit)
open-vm-tools-desktop
open-vm-tools-desktop(x86-64)
Unversioned so-files
--------------------
open-vm-tools: /usr/lib64/open-vm-tools/plugins/common/libhgfsServer.so
open-vm-tools: /usr/lib64/open-vm-tools/plugins/common/libvix.so
open-vm-tools: /usr/lib64/open-vm-tools/plugins/vmsvc/libguestInfo.so
open-vm-tools: /usr/lib64/open-vm-tools/plugins/vmsvc/libpowerOps.so
open-vm-tools: /usr/lib64/open-vm-tools/plugins/vmsvc/libtimeSync.so
open-vm-tools: /usr/lib64/open-vm-tools/plugins/vmsvc/libvmbackup.so
open-vm-tools-desktop:
/usr/lib64/open-vm-tools/plugins/vmusr/libdesktopEvents.so
open-vm-tools-desktop: /usr/lib64/open-vm-tools/plugins/vmusr/libdndcp.so
open-vm-tools-desktop:
/usr/lib64/open-vm-tools/plugins/vmusr/libresolutionSet.so
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=x2mA9M43do&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
