https://bugzilla.redhat.com/show_bug.cgi?id=982255

--- Comment #3 from Mario Ceresa <mrcer...@gmail.com> ---
Hi Ankur,
I have the following questions:

* I see there are some windows related files (labyrinth-0.6/Windows). They are
not installed but, if it's not too difficult, might you consider to remove
them?
* Why don't you use the full url as Source0?
* I think you should not call "rm -rf $RPM_BUILD_ROOT" at the beginning of
%install

Please answer to my comments and I'll continue the review.

Best,

Mario

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1qgKqku4Zh&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to