https://bugzilla.redhat.com/show_bug.cgi?id=982255
--- Comment #4 from Ankur Sinha (FranciscoD) <sanjay.an...@gmail.com> ---
(In reply to Mario Ceresa from comment #3)
> Hi Ankur,
Hi Mario,
> I have the following questions:
>
> * I see there are some windows related files (labyrinth-0.6/Windows). They
> are not installed but, if it's not too difficult, might you consider to
> remove them?
Deleted them
> * Why don't you use the full url as Source0?
I can't figure out a source url that ends with %{name}-%{version}.tar.gz. As
you'll see from the comment, the source ends with /%{version}.tar.gz but the
downloaded file is still %{name}-%{version}
> * I think you should not call "rm -rf $RPM_BUILD_ROOT" at the beginning of
> %install
Deleted.
>
> Please answer to my comments and I'll continue the review.
>
Thank you for the comments. I've updated the spec and srpms/rpms.
http://ankursinha.fedorapeople.org/labyrinth/labyrinth.spec
http://ankursinha.fedorapeople.org/labyrinth/labyrinth-0.6-1.fc20.src.rpm
http://ankursinha.fedorapeople.org/labyrinth/
Thanks,
Warm regards,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=nhWWPDzZUW&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
