https://bugzilla.redhat.com/show_bug.cgi?id=988193
--- Comment #10 from Michael Schwendt <bugs.mich...@gmx.net> ---
The scriptlets are wrong, though, and inconsistant.
> Just keep the same style with postun and posttrans.
Better forget about "style" and make them correct.
First of all, don't compare "touch" with "gtk-update-icon-cache". While touch
is a coreutils tool, gtk-update-icon-cache may not be installed. That's why you
want the scriptlets to _not_ fail when trying to run gtk-update-icon-cache when
it isn't found. Secondly, in the odd case that "touch" is not available either,
you could not touch the icon dirs, so the scriptlets would fail, too.
> %post
> touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null ||:
> touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null ||:
> touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null ||:
All three dirs are included in the package. And it's proper usage of "|| :"
here for allow for a missing "touch" command.
> %postun
> if [ $1 -eq 0 ] ; then
> touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null
> touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null
> touch --no-create %{_datadir}/icons/elementary-xfce-darker
> &>/dev/null
> gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce
> &>/dev/null
> gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-dark
&>/dev/null
> gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-darker
&>/dev/null ||:
> fi
Here, "|| :" should be added at the end of all lines. It makes no sense to add
it to just the last line, because the previous two lines would fail already if
gtk-update-icon-cache didn't exist. Similarly for "touch".
> %posttrans
> gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce
> &>/dev/null
> gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-dark
&>/dev/null
> gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-darker
&>/dev/null ||:
Same here. "|| :" at the end of all lines would achieve what it's supposed to
do.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=BFyarZ285b&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
