https://bugzilla.redhat.com/show_bug.cgi?id=988193
--- Comment #11 from Raphael Groner <raph...@web.de> --- (In reply to Michael Schwendt from comment #10) … > First of all, don't compare "touch" with "gtk-update-icon-cache". While > touch is a coreutils tool, gtk-update-icon-cache may not be installed. > That's why you want the scriptlets to _not_ fail when trying to run > gtk-update-icon-cache when it isn't found. Secondly, in the odd case that > "touch" is not available either, you could not touch the icon dirs, so the > scriptlets would fail, too. … I suggest to use 'if [ -x "$file" ]' therefore, where $file means '/usr/bin/touch' and '/usr/bin/gtk-update-icon-cache'. It could skip the whole touch or gtk-update-icon-cache calls individually cause of one false check at the beginning without trying several times to execute something that does not exist or is not marked as executable. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yI96SpNW8h&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
