https://bugzilla.redhat.com/show_bug.cgi?id=993456

Joshua Small <techn...@lolware.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |techn...@lolware.net



--- Comment #1 from Joshua Small <techn...@lolware.net> ---
Hi,

This is an informal review as I cannot sponsor.

I have run a koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5787741

I did notice a build error:
configure: WARNING: unrecognized options: --disable-static
Although this flag is often recommended, as I'm seeing that the configure
script doesn't recognise it, it should probably be removed.

There appears to be a significant amount of documentation that may be better
served by a separate -doc rpm.

rpmlint looks clean.

I noted Source0 expands to
http://www.coin-or.org/download/source/metslib-0.5.3.tgz, which currently
provides a 404 error for me.

These minor points are the only ones I have been able to raise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gbv5Baih2j&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to