https://bugzilla.redhat.com/show_bug.cgi?id=993456



--- Comment #5 from Rich Mattes <richmat...@gmail.com> ---
Thanks for taking a look.  Updated packages:

Spec URL: http://rmattes.fedorapeople.org/RPMS/metslib/metslib.spec
SRPM URL:
http://rmattes.fedorapeople.org/RPMS/metslib/metslib-0.5.3-2.fc19.src.rpm

I submitted a bug report upstream asking for clarification of the
abstract_search.hh license:
https://projects.coin-or.org/metslib/ticket/3
I will also ask about including a copy of the license text.

As far as the BuildArch: goes, we ran into the same sort of issue with the
eigen3 package recently.  It is good to be able to run the unit tests on all
architectures, but there isn't a need to have arch specific packages.  We ended
up doing what you suggested: only marking the -devel package as noarch, so that
all builders will run the unit tests, and disabling the debuginfo generation
since there are no binaries to strip.  I did the same to this package.

I provided %{name} = %{version}-%{release} more for convenience at install-time
rather than for packaging purposes.  I agree it's not really necessary though
so I removed it.

The -O3 and .la removal have been fixed.  I also removed all references to the
libdir from the pkgconfig file (they're not necessary.)


$ rpmlint metslib.spec ../RPMS/noarch/metslib-devel-0.5.3-2.fc19.noarch.rpm 
metslib-devel.noarch: W: spelling-error Summary(en_US) Metaheuristic -> Meta
heuristic, Meta-heuristic, Heuristics
metslib-devel.noarch: W: spelling-error %description -l en_US metaheuristic ->
meta heuristic, meta-heuristic, heuristics
1 packages and 1 specfiles checked; 0 errors, 2 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=crFE9auJcX&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to