https://bugzilla.redhat.com/show_bug.cgi?id=996489
Josef Stribny <jstri...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #2 from Josef Stribny <jstri...@redhat.com> ---
1, Please remove the trailing white space:
* after BuildRequires: rubygems-devel
* after BuildRequires: rubygem(test-unit)
2, Please put the dot at the end of -doc subpackage description
3, Should the license be "X11 or MIT" (taken from the README)? Since only MIT
is included as a standalone file and in the .gemspec, it's probably better to
list only MIT. Maybe you can ask upstream for clarification?
Otherwise the spec is alright, it builds, installs and runs, rpmlint doesn't
complaint and the issues mentioned above are minor so I am APPROVING the
package. Please resolve the issues above before pushing.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=2SXO4AcLUK&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
