https://bugzilla.redhat.com/show_bug.cgi?id=1020839
--- Comment #9 from Adam Williamson <awill...@redhat.com> --- Going through the review process, consider all 'MUST' and 'SHOULD' elements as OK unless posted here... rpmlint output: [adamw@vaioz noarch]$ rpmlint fedora-gooey-karma-0.1-1.fc20.noarch.rpm fedora-gooey-karma.noarch: W: no-documentation fedora-gooey-karma.noarch: E: script-without-shebang /usr/share/fedora-gooey-karma/mainwindow_gui.py fedora-gooey-karma.noarch: W: no-manual-page-for-binary fedora-gooey-karma 1 packages and 0 specfiles checked; 1 errors, 2 warnings. [adamw@vaioz noarch]$ rpmlint ../../SRPMS/fedora-gooey-karma-0.1-1.fc20.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. script-without-shebang noted above, the entire lack of documentation may or may not be a problem for a fairly 'trivial' app. MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc - this is not done, the package includes a COPYING file (GPLv3) but it is not packaged. MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. - see note about python file above SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. - there aren't any, as noted by rpmlint. But it probably doesn't make sense to have one for a simple command/app which probably takes no or few arguments. I'm assuming it's permissible to simply ignore the Python guidelines when you're not actually packaging a Python module, but just a little app which happens to be a pile of Python code, otherwise this would be completely out of line with the requirements. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
