https://bugzilla.redhat.com/show_bug.cgi?id=1020839
Terje Røsten <terje...@phys.ntnu.no> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |terje...@phys.ntnu.no
--- Comment #10 from Terje Røsten <terje...@phys.ntnu.no> ---
Some comments:
- spec file mixes $RPM_BUILD_ROOT and %{buildroot}, pick one form only.
- %clean section is not needed:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean
- %defattr is not needed:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions
Add leading space when using \ :
desktop-file-install \
--dir=%{buildroot}%{_datadir}/applications \
%{buildroot}/%{_datadir}/applications/fedora-gooey-karma.desktop
- Most of empty lines seems unneeded.
- Summary is cryptic, please improve.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
