https://bugzilla.redhat.com/show_bug.cgi?id=1074268
David Dick <dd...@cpan.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dd...@cpan.org
Assignee|nob...@fedoraproject.org |dd...@cpan.org
Flags| |fedora-review?
--- Comment #1 from David Dick <dd...@cpan.org> ---
Items marked as TODO are optional but recommended fixes; FIX are review
blockers.
TODO: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines notes that
the MIT license requires the license file itself to be included in a
distribution of the package. The MIT license file is not included in the
package. Please co-ordinate with upstream to correct this.
TODO: Utilize DESTDIR instead of PERL_INSTALL_ROOT, line 34.
TODO: Remove META.json and cpanfile from %doc; these files are of no use to the
end users, line 45
Dependencies:
You'll need to BuildRequire all the use'd and require'd modules to prevent
possible future build failures caused by buildroot change
FIX: BR perl
FIX: BR perl(File::Temp)
FIX: BR perl(strict)
FIX: BR perl(warnings)
FIX: BR perl(FindBin)
FIX: BR perl(Fcntl)
FIX: BR perl(Socket)
FIX: BR perl(POSIX)
FIX: BR perl(URI::Escape)
FIX: BR perl(Cwd)
FIX: BR perl(Carp)
FIX: BR perl(vars)
FIX: BR perl(Config)
FIX: BR perl(base)
FIX: BR perl(File::Find)
FIX: BR perl(File::Path)
FIX: BR perl(Plack::Runner)
FIX: Drop the Plack BR, it is not use'd or require'd.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
