https://bugzilla.redhat.com/show_bug.cgi?id=1074268
--- Comment #2 from Emmanuel Seyman <emman...@seyman.fr> --- (In reply to David Dick from comment #1) > > TODO: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines notes > that the MIT license requires the license file itself to be included in a > distribution of the package. The MIT license file is not included in the > package. Please co-ordinate with upstream to correct this. Indeed. I've filed bug #93868 on rt.cpan.org, asking the author to include the text of the MIT license with the tarball. > TODO: Utilize DESTDIR instead of PERL_INSTALL_ROOT, line 34. Done. > TODO: Remove META.json and cpanfile from %doc; these files are of no use to > the end users, line 45 Agreed. Done. > Dependencies: > You'll need to BuildRequire all the use'd and require'd modules to prevent > possible future build failures caused by buildroot change > > FIX: BR perl I have to admit that putting perl as a BR seems a little strange. Nevertheless, I've included it. > FIX: BR perl(File::Temp) > FIX: BR perl(strict) > FIX: BR perl(warnings) > FIX: BR perl(FindBin) > FIX: BR perl(Fcntl) > FIX: BR perl(Socket) > FIX: BR perl(POSIX) > FIX: BR perl(URI::Escape) > FIX: BR perl(Cwd) > FIX: BR perl(Carp) > FIX: BR perl(vars) > FIX: BR perl(Config) > FIX: BR perl(base) > FIX: BR perl(File::Find) > FIX: BR perl(File::Path) > FIX: BR perl(Plack::Runner) Added. > FIX: Drop the Plack BR, it is not use'd or require'd. Removed. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk-0.12-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
