https://bugzilla.redhat.com/show_bug.cgi?id=1073978
--- Comment #9 from Kalev Lember <kalevlem...@gmail.com> --- (In reply to Adrien Vergé from comment #7) > I have reviewed the latest submission in the list: > https://bugzilla.redhat.com/show_bug.cgi?id=1079064 > and I'll do others soon. Excellent! Unfortunately, it's another FE-NEEDSPONSOR ticket and you won't be able to officially approve that package once you are sponsored. Oh well, I guess we could use more sponsors. Anyway, regarding the comments in the other ticket: > Replace $RPM_BUILD_ROOT with %{buildroot} Either one is actually fine as per https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS > From what I read in your Makefile: > LIBS = $(SDL_LDFLAGS) -lSDL_image -lSDL_mixer -lexpat -lSDL_ttf -lphysfs \ > -lboost_filesystem -lboost_system -lpng > your package depends on some libraries. You need to declare them explicitely > with Requires entries. Please refer to this section: For C and C++, rpm includes a shared library dependency generator. It looks at what libraries the executable uses (DT_NEEDED entries), and adds rpm Requires automatically based on that. In your case here, the package is a Python program and RPM does not have a dependency generator for this, so you need to specify the Requires manually. For C code like btbuilder, it's actually the other way around -- it's recommended to have rpm take care of dependencies and not add manual Requires. https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review