https://bugzilla.redhat.com/show_bug.cgi?id=1073978
Kalev Lember <kalevlem...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #10 from Kalev Lember <kalevlem...@gmail.com> --- Fedora review photocollage-1.0.1-1.src.rpm 2014-03-21 $ rpmlint photocollage \ photocollage-1.0.1-1.src.rpm photocollage.noarch: W: no-manual-page-for-binary photocollage photocollage.src: W: non-coherent-filename photocollage-1.0.1-1.src.rpm photocollage-1.0.1-1.fc20.src.rpm 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The package contains the license file (LICENSE) + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm 4334865175d8e12287155766930de57d photocollage-1.0.1.tar.gz 4334865175d8e12287155766930de57d Download/photocollage-1.0.1.tar.gz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane + The spec file handles locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages should not contain libtool .la files + Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Just a small nit with %changelog section. In Fedora, it's common to have an empty newline between two changelog entries, such as: * Thu Mar 20 2014 Adrien Vergé <adrienve...@gmail.com> - 1.0.1-1 - Add license headers in source files * Wed Mar 5 2014 Adrien Vergé <adrienve...@gmail.com> - 1.0-1 - initial build Another thing I've noticed is that the package crashes about half the time after clicking on 'Preview poster' with the following spew on the console. No idea where this comes from, maybe something wrong down in the stack. [xcb] Unknown sequence number while processing queue [xcb] Most likely this is a multi-threaded client and XInitThreads has not been called [xcb] Aborting, sorry about that. python3: xcb_io.c:274: poll_for_event: Assertion `!xcb_xlib_threads_sequence_lost' failed. Aborted Anyway, the package looks good to me to go in! APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review