https://bugzilla.redhat.com/show_bug.cgi?id=1088946
Ralf Corsepius <rc040...@freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rc040...@freenet.de
Assignee|nob...@fedoraproject.org |rc040...@freenet.de
Flags| |fedora-review+
--- Comment #2 from Ralf Corsepius <rc040...@freenet.de> ---
Though I personally am not a friend of the inc/ removal and see several other
details within this spec, which do not fit my personal preferences, this
package is OK.
2 remarks:
* I'd recommend to at least add a comment to the spec explaining why you are
removing inc/.
* One minor oversight:
%install
rm -rf %{buildroot}
As you do not support older RHELs in this spec, this rm should be removed.
Anyway, APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
