https://bugzilla.redhat.com/show_bug.cgi?id=1171624
Antonio Trande <anto.tra...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anto.tra...@gmail.com
--- Comment #8 from Antonio Trande <anto.tra...@gmail.com> ---
(In reply to Arnaud Gelas from comment #7)
> I have fixed these issues in the latest version
>
> https://dl.dropboxusercontent.com/u/15135983/statismo.spec
> https://dl.dropboxusercontent.com/u/15135983/statismo-0.10.1-2.fc20.src.rpm
>
> Thanks
Good!
Just some additional comments.
- I think that 'parallel make' macro will work on Fedora RPM build-system.
- devel sub-package does not need to contain LICENSE and Readme files because
it depends by main package that already packages them.
- Instead, doc sub-package must to list LICENSE by using %license macro because
it does not require any other package to be installed.
- %dir %{_libdir}/cmake/
%dir macro defines the ownership of a directory but if you use
%{_libdir}/cmake/
the directory %{_libdir}/cmake and all files/directories within will be owned.
See
http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
and in particular
http://fedoraproject.org/wiki/Packaging:UnownedDirectories
- Fix this warning
W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
