https://bugzilla.redhat.com/show_bug.cgi?id=1172525
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbys...@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
It's best not to use temporary places like fpaste for spec files. If you don't
have better place, attach it to this bug.
You can use mkdir to create a directory. '%{__install} -d' is a bit hard to
read ;)
Also pushd is considered nicer than cd, because the path is printed to the log.
From line 17 remove everything except possibly protobuf, not sure about that
one. Dependencies on libraries are added automatically.
Remove lines 38, 44, 45, 48, 49, and 6 too.
Remove line 40, and add -D to Line 42 instead.
Use %license for LICENSE instead of %doc.
In line 51, use %{name}.1.* instead of %{name}.1.gz, since the compression
method might change at some point, no need to adjust the spec file for that.
Can't sponsor you, but otherwise looks OK.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
