https://bugzilla.redhat.com/show_bug.cgi?id=1203018
--- Comment #5 from Dominik 'Rathann' Mierzejewski <domi...@greysector.net> --- Some quick comments. 1. You should give full URL to the source tarball in Source0:, not just the filename (it should be downloadable with curl/wget). 2. You should provide systemd units instead of SysV-style initscripts. 3. Does it work only with lighttpd? If not, you should provide configurations for all supported webservers. 4. Your versioning scheme is wrong, please check https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning , especially the snapshot versioning part. 5. The service should work with SELinux in enforcing mode by default, you should either include and install the necessary policy in your package or file a bug against selinux-policy to include it there. 6. LICENSE file should be included with %license macro, not as %doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
