https://bugzilla.redhat.com/show_bug.cgi?id=1193923
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbys...@in.waw.pl
--- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
Yeah, package looks good. @Christopher: would you mind if I finish the review?
- Consider using %make_install instead of the open-coded make install ...
fedora-review complains:
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /var/tmp/review-
rc/1193923-mbedtls/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
- Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: mbedtls-devel. Does not provide -static:
mbedtls-devel.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40683520 bytes in 1423 files.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
