https://bugzilla.redhat.com/show_bug.cgi?id=1193923
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|i...@cicku.me |zbys...@in.waw.pl
--- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
OK, since this a re-review, just the relevant points:
- spec file is nice and clean
- license is OK, but there's an additional exception. I think the license
should be 'GPLv2+ with exceptions', and a link provided to
https://tls.mbed.org/foss-license-exception in a comment. This extends
available options (compared to GPLv2+).
- provides/obsoletes are not OK:
According to
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages,
Obsoletes should have a concrete version number. It seems that %{?_isa} should
also be used, as the package is an arch dependent libary.
Obsoletes: polarssl%{?_isa} < 1.3.10
Provides: polarssl%{?_isa} = %{version}-%{release}
I tried upgrading a system with polarssl-devel installed. It fails:
Error: package polarssl-devel-1.3.9-3.fc22.x86_64 requires
libpolarssl.so.7()(64bit), but none of the providers can be installed
It seems that more obs/provs should be added:
In -devel:
Obsoletes: polarssl-devel%{?_isa} < 1.3.10
Provides: polarssl-devel%{?_isa} = %{version}-%{release}
In -utils:
Obsoletes: polarssl-utils < 1.3.10
Provides: polarssl-utils = %{version}-%{release}
I'm not 100% sure about the exact form though. Please check that upgrading
works :)
- doc subpackage should be noarch.
- I'd suggest adding:
%global _docdir_fmt %{name}
Currently there's /usr/share/doc/mbedtls with one file, and
/usr/share/doc/mbedtls-doc with the rest. No use to have two directories.
Some details pointed out by rpmlint:
mbedtls.src:67: W: macro-in-comment %check
mbedtls.src:45: W: mixed-use-of-spaces-and-tabs (spaces: line 26, tab: line 45)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
