https://bugzilla.redhat.com/show_bug.cgi?id=1287756
Mikolaj Izdebski <mizde...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mizde...@redhat.com
Assignee|nob...@fedoraproject.org |mizde...@redhat.com
Flags| |fedora-review?
--- Comment #3 from Mikolaj Izdebski <mizde...@redhat.com> ---
Major issues:
In general, "When naming packages for Fedora, the maintainer must use the dash
'-' as the delimiter for name parts. The maintainer must NOT use an underscore
'_'" [1]
There is no license file installed. You should add license file to upstream
repo and install it using %license macro.
Source0 based on hg repo tip is a bad idea. You should use proper tags
(preferably) or revision numbers / commit IDs.
Minor/cosmetic issues:
- "Epoch: 0" line is not needed.
- Empty sections (%prep, %install) can be removed.
- "rm -rf $RPM_BUILD_ROOT" is not needed.
- Group: tag is useless, consider removing it.
[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
