https://bugzilla.redhat.com/show_bug.cgi?id=1287822
Michael Scherer <m...@zarb.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m...@zarb.org
--- Comment #3 from Michael Scherer <m...@zarb.org> ---
So the 330 bundled provides make me sad at the idea of maintaining a stable
version and bug fixes, but I guess since guidelines have been relaxed, that's
acceptable.
However, I have a few questions:
- Why is there test for %if "%{dist}" == ".el7aos" ? Is this specs file
supposed to be used for more than Fedora/EPEL ?
- you should remove %defattr around, since that's no longer needed.
- why a obsolete, since that's a new package ? (ie, we usually do not deal with
externnal package to Fedora in Fedora, so why the exception for this one ?)
- the summary is not that helpful, and description is just a copy of the
summary
- the specs file mention it being generated directly by upstream. I am not sure
if that's a common practice, as it was refused for sugar, for example.
- License must be tagged %license.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
