https://bugzilla.redhat.com/show_bug.cgi?id=1287822
--- Comment #10 from Michael Scherer <m...@zarb.org> ---
- Also, there is a missing deps on procps-ng in the sdn-ovs subpackage,
required for sysctl, and since procps-ng is not installed by default in a
docker container, I think it should be made explicit, even if I suspect I am
just being pedantic for this one.
The same go for iproute (required for the 'ip' tools).
- there is also a different name for the files in the sdn-ovs subpackage:
%files sdn-ovs
%dir %{_unitdir}/origin-node.service.d/
...
%{_unitdir}/%{name}-node.service.d/openshift-sdn-ovs.conf
I think there is a warning on using the same macro everywhere.
- %{_sysconfdir}/origin/.config_managed should be marked as ghost.
- Haikel guemard also noted that if this package install files in
/usr/bin/kubernetes, we would need some conflict at the rpm level.
- Since sdn-ovs change systemd configuration ( by adding 2 files for docker and
origin ), shouldn't it reload systemd in %post ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
