https://bugzilla.redhat.com/show_bug.cgi?id=1294842



--- Comment #2 from Pier Luigi Fiorini <pierluigi.fior...@gmail.com> ---
naming: ok

sources: ok
SHA1 0d4d2fb6897eb84cab42705d6a4f16f901f5aa2d libkdcraw-15.12.0.tar.xz

license: ok

ldconfig post/postun: ok

files: ok though I have an observation.

subdirs are not owned by any other package so they should be %dir, shouldn't
they?

Like:

%files devel
%{_kf5_libdir}/libKF5KDcraw.so
%{_kf5_includedir}/libkdcraw_version.h
%dir %{_kf5_includedir}/KDCRAW/
%{_kf5_includedir}/KDCRAW/*
%dir %{_kf5_libdir}/cmake/KF5KDcraw/
%{_kf5_libdir}/cmake/KF5KDcraw/*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to