https://bugzilla.redhat.com/show_bug.cgi?id=1304882
--- Comment #12 from awill...@redhat.com <awill...@redhat.com> ---
"%{?systemd_requires} is forbidden by the guidelines. I don't think we gain
anything by that rule, but it's on the books."
Thanks, I'll...er...do something about that?
"What about parallel build?"
The compile step is pretty short anyhow, so I guess I never thought about it. I
can see.
"I think user/group creation scriptlets should be suffixed with "|| :".
They should not be fatal to installation."
Well, there are samples on the policy page for those, and they don't have "||
:". https://fedoraproject.org/wiki/Packaging:UsersAndGroups
"Also emitting message from %post is a bit unusual."
Yeah, it's kinda unusual for Fedora I guess, but it seemed useful so I kept it.
Of course it should at least be in the httpd subpackage now :) Maybe I can add
a README or something instead, I'll see what I feel.
"Strictly speaking, the generator is wrong, because generators cannot rely on
/var being mounted. It will not operate correctly if someone has a system with
separate /var partitions."
Is there a fix or change you can recommend? Honestly this just came from the
SUSE spec, I don't even know what it does.
"It seems a bit strange to use both the tmpfiles mechanism and explicit
creation of files in a script (the log file). I think it would be cleaner to
use a tmpfile also for the log file."
Another thing straight from SUSE - IIRC, one bit is rather older than the
other. I'll look at it.
"Doesn't this do just that: create a directory owned by geekotest?"
Y'know, I've always kinda wondered about that too. My *guess* is that this is
actually some kind of note added by a SUSE watchdog, either manual or some
kinda automated script - i.e. it was meant as a warning to the packagers, it's
not something the packagers themselves added. I'll ask the openSUSE folks about
it.
[directory ownership] - yep, you're right, will fix. I even explicitly added
the httpd-filesystem dep then forgot to remove the directory ownership.
Thanks for the notes! Expect a new build tomorrow.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
