https://bugzilla.redhat.com/show_bug.cgi?id=1310793
Richard Shaw <hobbes1...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1...@gmail.com
--- Comment #2 from Richard Shaw <hobbes1...@gmail.com> ---
A quick spec review on my lunch break...
1. rpmbuild doesn't care but typically %{pre,post,postun,etc} would be after
%install
2. In %build, why is the debug package being disabled? Typically this is only
permitted for noarch packages where it doesn't produce anything useful.
3a. A license file only needs to be included in one package assuming the other
requires it (in this case -devel requires the base package)
3b. License files should use the %license macro rather than %doc.
3c. Since a readme file is provided it should be included in the base package
with %doc.
So all that to say the base package should be updated to:
%license license.txt
%doc README.md
4. Typo in the description at the beginning of the -devel package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
