https://bugzilla.redhat.com/show_bug.cgi?id=1310793



--- Comment #4 from Richard Shaw <hobbes1...@gmail.com> ---
(In reply to Paulo Henrique Rodrigues Pinheiro from comment #3)
> (In reply to Richard Shaw from comment #2)
> 
> > 2. In %build, why is the debug package being disabled? Typically this is
> > only permitted for noarch packages where it doesn't produce anything useful.
> 
> I followed the directions of the documentation* to see if it was a recurring
> problem, but could not make the debug package be generated.
> 
> * https://fedoraproject.org/wiki/Packaging:Debuginfo?rd=Packaging/Debuginfo
> 
> After this, to "silent" rpmlint, I put a strip in make install.

Not sure what is going on here, I removed the strip command and get a usable
debuginfo package.


> > 3a. A license file only needs to be included in one package assuming the
> > other requires it (in this case -devel requires the base package)
> 
> OK, I put this because rpmlint give-me "no-documentation" :)

Yes, it's just warning you, since upstream doesn't provide any that's OK.


> > 3c. Since a readme file is provided it should be included in the base
> > package with %doc.
> 
> There's no README.md, only license.txt...

I just noticed that, I was looking at it in github where there is one. Has
there just not been a release since it was added?


> Can I leave rpmlint with these warnings? My output:
> 
> [paulohrpinheiro@localhost SPECS]$ rpmlint unqlite.spec
> ../RPMS/x86_64/unqlite-*
> unqlite.x86_64: W: no-documentation
> unqlite-devel.x86_64: W: no-documentation
> 2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Yes, that's OK.

Also, just playing around a bit with the Makefile, after removing the strip
command I added a symbolic link to the library to go in the -devel package:

ln -rs $(LIBDIR)/$(LIBNAME) $(LIBDIR)/libunqlite.so

Then added to the spec:

%files devel
%{_includedir}/unqlite.h
%{_libdir}/libunqlite.so

This is typically needed as a project using this for a dependency wouldn't
necessarily know about the soversion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to