https://bugzilla.redhat.com/show_bug.cgi?id=1373218
Igor Gnatenko <ignate...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org |ignate...@redhat.com
Flags| |fedora-review?
--- Comment #3 from Igor Gnatenko <ignate...@redhat.com> ---
* Missing BuildRequires: gcc
* I think you don't really need to package static library
> Source0:
> https://github.com/facebook/zstd/archive/v1.0.0.tar.gz#/%{name}-%{version}.tar.gz
Source0:
https://github.com/facebook/zstd/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
> Patch0: zstd-lib-no-rebuild.patch
Write comment where you sent this patch upstream or why it's not applicable for
upstream
> %{?__global_ldflags:LDFLAGS="%__global_ldflags"}
no need for this
> CFLAGS="$RPM_OPT_FLAGS" LDFLAGS=$LDFLAGS make %{?_smp_mflags} -C "$dir"
CFLAGS="%{optflags}" LDFLAGS="%{__global_ldflags}" %make_build -C $dir
> make -C tests test-zstd
didn't check but I think you have to export CFLAGS/LDFLAGS here as well
> make install \
> DESTDIR=$RPM_BUILD_ROOT \
> PREFIX=%{_prefix} \
> LIBDIR=%{_libdir}
%make_install PREFIX=%{_prefix} LIBDIR=%{_libdir}
> /usr/bin/zstd
%{_bindir}/%{name}
> /usr/bin/unzstd
%{_bindir}/un%{name}
> /usr/bin/zstdcat
%{_bindir}/%{name}cat
> /usr/share/man/man1/zstd.1.gz
%{_mandir}/man1/%{name}.1*
> /usr/share/man/man1/unzstd.1.gz
%{_mandir}/man1/un%{name}.1*
> /usr/share/man/man1/zstdcat.1.gz
%{_mandir}/man1/%{name}cat.1*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
