https://bugzilla.redhat.com/show_bug.cgi?id=1373218
Michael Cullen <mich...@cullen-online.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mich...@cullen-online.com
--- Comment #6 from Michael Cullen <mich...@cullen-online.com> ---
In order to keep this moving, here are some comments:
Personally, I'd prefer to see a comment in the spec file so I don't have to
open the patch files to see what they do.
Secondly, there's a new release you should package (1.1.0) but it was only
released yesterday so I understand why it isn't here.
Here's a review from fedora-review. Mostly it looks alright, but I'm concerned
about the licenses around the examples. also, that static library really
shouldn't exist!
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: libzstd-devel. Does not provide -static:
libzstd-devel.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Newer version is now available
- LICENSE-examples not added as a license file, but examples are shipped
- According to LICENSE-examples, examples are "for non-commercial testing and
evaluation purposes only" which is not acceptable in Fedora packages
- example Makefile is GPLv2 which should be added to the license list in the
-devel package at least
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
like)", "zlib/libpng", "BSD (3 clause)", "BSD (2 clause)". 110 files
have unknown license. Detailed output of licensecheck in
/home/rpmbuilder/1373218-zstd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 10 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libzstd
, zstd-debuginfo
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: zstd-1.0.0-2.fc23.x86_64.rpm
libzstd-1.0.0-2.fc23.x86_64.rpm
libzstd-devel-1.0.0-2.fc23.x86_64.rpm
zstd-debuginfo-1.0.0-2.fc23.x86_64.rpm
zstd-1.0.0-2.fc23.src.rpm
zstd.x86_64: W: name-repeated-in-summary C Zstd
zstd.x86_64: W: spelling-error %description -l en_US lossless -> loss less,
loss-less, loveless
zstd.x86_64: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
libzstd.x86_64: W: spelling-error Summary(en_US) Zstd -> Std, Z std
libzstd.x86_64: W: spelling-error %description -l en_US Zstandard -> Standard,
Z standard, Hardstand
libzstd.x86_64: W: no-documentation
zstd.src: W: name-repeated-in-summary C Zstd
zstd.src: W: spelling-error %description -l en_US lossless -> loss less,
loss-less, loveless
zstd.src: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
5 packages and 0 specfiles checked; 0 errors, 9 warnings.
Rpmlint (debuginfo)
-------------------
Checking: zstd-debuginfo-1.0.0-2.fc23.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
zstd.x86_64: W: name-repeated-in-summary C Zstd
libzstd.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
Requires
--------
zstd (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
rtld(GNU_HASH)
libzstd (rpmlib, GLIBC filtered):
/sbin/ldconfig
libc.so.6()(64bit)
rtld(GNU_HASH)
libzstd-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
libzstd(x86-64)
libzstd.so.1()(64bit)
zstd-debuginfo (rpmlib, GLIBC filtered):
Provides
--------
zstd:
zstd
zstd(x86-64)
libzstd:
libzstd
libzstd(x86-64)
libzstd.so.1()(64bit)
libzstd-devel:
libzstd-devel
libzstd-devel(x86-64)
pkgconfig(libzstd)
zstd-debuginfo:
zstd-debuginfo
zstd-debuginfo(x86-64)
Source checksums
----------------
https://github.com/facebook/zstd/archive/v1.0.0.tar.gz#/zstd-1.0.0.tar.gz :
CHECKSUM(SHA256) this package :
197e6ef74da878cbf72844f38461bb18129d144fd5221b3598e973ecda6f5963
CHECKSUM(SHA256) upstream package :
197e6ef74da878cbf72844f38461bb18129d144fd5221b3598e973ecda6f5963
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1373218
Buildroot used: fedora-23-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
