https://bugzilla.redhat.com/show_bug.cgi?id=1366047
Tomas Mraz <tm...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tm...@redhat.com
Assignee|nob...@fedoraproject.org |tm...@redhat.com
Flags| |fedora-review?
--- Comment #23 from Tomas Mraz <tm...@redhat.com> ---
I'll review this package.
My comments:
Use ExclusiveArch instead of BuildArch and in general follow
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#Architecture_Support
If the reason for building on just the architectures specified is that the
other platforms do not have the hardware needed, then please at least add a
comment about this fact to the spec.
The build is nonstandard and does not apply RPM_OPT_FLAGS and LDFLAGS during
the build which means that hardening and optimalization is not applied. This
must be fixed too.
%attr(0755,root,root) %{_libdir}/*.so
- %attr is not applicable to symlink
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
