https://bugzilla.redhat.com/show_bug.cgi?id=1373782
Jakub Hrozek <jhro...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #1 from Jakub Hrozek <jhro...@redhat.com> ---
I have some questions and comments:
1) we released cmocka 1.1 last week. I think this version should be packaged.
2) could you report the issue with LargestIntegralType upstream?
3) The same for the pkg-config file, it would be nicer to have no workarounds
in Fedora (although I wouldn't block the review over this)
4) maybe this is me not understanding the mingw packaging well (this is the
first mingw package I am reviewing..) but is it expected there is no -devel
package? I haven't found any notice about that in
https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW
5) A similar question about a -static package which we have in the native
packaging scheme
6) The fedora-review tool suggests there are some unowned reviews:
Note: Directories without known owners: /usr/x86_64-w64-mingw32/sys-
root/mingw/include/cmockery, /usr/x86_64-w64-mingw32/sys-
root/mingw/lib/cmake/cmocka, /usr/i686-w64-mingw32/sys-
root/mingw/include/cmockery, /usr/i686-w64-mingw32/sys-
root/mingw/lib/cmake/cmocka
The rest looks good to me.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
