https://bugzilla.redhat.com/show_bug.cgi?id=1411984
--- Comment #4 from Kees de Jong <keesdejong+b...@gmail.com> ---
I think I added all the (In reply to Mikolaj Izdebski from comment #1)
> SRPM URL points to HTML document.
> You should include your FAS account name.
>
> Spec file looks quite good. The only real problem I can see from it is that
> the package should own the whole %{_datadir}/%{name}. Also "rm -rf
> %{buildroot}" are not needed and should be removed.
FAS account is 'aqual1te', my OpenPGP key is still syncing across the SKS
servers, but can be found on this pool of servers already:
https://sks-keyservers.net/pks/lookup?op=vindex&search=0x0E45C98AB51428E6&fingerprint=on&exact=on
If there is no result, hit F5, the pool of servers is rotating the requests in
round robin. Most of the servers in the pool have my key already.
Please let me know if I corrected the problems now for the package (links
below).
(In reply to Michael Schwendt from comment #2)
> > %build
> >
> > %install
>
> Also be aware of:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
>
>
> > install -m755 config/config %{buildroot}%{_datadir}/%{name}/config
>
> There is no other configuration method in /etc or so? Just this executable
> shell script?
>
>
> > install -m644 %{name}.* %{buildroot}%{_mandir}/man1
>
> > %{_mandir}/man1/%{name}.1.gz
>
> More correct would be
>
> %{_mandir}/man1/%{name}.1*
>
> which would cover uncompressed manual pages as well as different
> compression, because the gzip compression of manual pages is not explicitly
> done inside this spec file but performed by rpmbuild on-the-fly depending on
> default rpmbuild configuration.
There is no system-wide configuration in e.g. /etc. When the script is ran for
the first time it copies a config to ~/.config/neofetch. I added your
suggestions, thanks!
(In reply to M. Herdiansyah from comment #3)
> Hello, I am one of the contributors of neofetch, and the maintainer for the
> third-party package for neofetch in copr.
>
> My only concern will be in
>
> >%install
>
> Since neofetch does have a Makefile, won't it be better to use
>
> %make_install
>
> instead of copying the files manually?
>
> Also, for
>
> > %{_datadir}/%{name}/ascii/distro/*
> > %{_datadir}/%{name}/config
>
> We can simplify it to
>
> %{_datadir}/%{name}/*
Because of the suggestions from comment #2 I couldn't use the Makefile. This is
because of the timestamps that need to be preserved. But still a very useful
suggestions just like your other suggestions. I added them.
Spec file: https://github.com/AquaL1te/neofetch/blob/master/neofetch.spec
SRPM:
https://github.com/AquaL1te/neofetch/raw/master/neofetch-2.0.2-1.fc25.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
