https://bugzilla.redhat.com/show_bug.cgi?id=1419122

Vít Ondruch <vondr...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondr...@redhat.com



--- Comment #17 from Vít Ondruch <vondr...@redhat.com> ---
(In reply to Sascha Spreitzer from comment #13)
> Hi Marcel
> 
> (In reply to Marcel Haerry from comment #9)
> > gem_install:
> > 
> > I don't really understand the problem with %gem_install, as I am using it:
> > 
> > http://git.scrit.ch/srpm/rubygem-base32/tree/SPECS/rubygem-base32.spec#n46
> > 
> > AND I think I closely follow the guidelines in the wiki
> > 
> > https://fedoraproject.org/wiki/Packaging:Ruby#.25build
> > 
> > Is the review test broken here? Can you otherwise be more specific?
> 
> The fedora-review tool is highlighting the %gem_install being missed, but i
> can see it in the spec file. And additionally there is an %install section.
> Please give me some time to find out why fedora-review is failing and if
> %install in addition to %gem_install is permissible.

Not sure why fedora-review is complaining, but the %gem_install and %install
section are correct IMO. Please note that the %gem_install works in the context
of %{_builddir} while the code in %install section assures that the gem content
is copied from %{_builddir} into %{_buildrootdir}, where RPM can pick it up for
packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to