https://bugzilla.redhat.com/show_bug.cgi?id=1471056

Matthias Runge <mru...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mru...@redhat.com



--- Comment #12 from Matthias Runge <mru...@redhat.com> ---
A few more remarks:
- please separate changelog entries by empty lines:

* Tue Aug 22 2017 Marc Dequènes (Duck) <d...@redhat.com> -
1.4-5.20170118gita77bf99
- remove %%clean section, not needed in Fedora

* Tue Aug 22 2017 Marc Dequènes (Duck) <d...@redhat.com> -
1.4-4.20170118gita77bf99
- don't remove secret file during upgrade
- start service at the end of post scriptlet
- improve SELinux rules handling (now requires a running SELinux)

* Tue Aug 22 2017 Marc Dequènes (Duck) <d...@redhat.com> -
1.4-3.20170118gita77bf99


you shouldn't remove buildroot and create it again. That can be expected to be
clean 
(begin of %install section)

On irc, you mentioned another package waiting for review. Please point me to
that, I might be able to get you sponsor you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to