https://bugzilla.redhat.com/show_bug.cgi?id=1471056
Andreas Thienemann <andr...@bawue.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andr...@bawue.net
--- Comment #18 from Andreas Thienemann <andr...@bawue.net> ---
Thank you for submitting the package and doing all the work to get it into
Fedora.
I did notice one thing about the .spec file though I did not like. The handling
of the postsrsd.secret file could be improved.
I like that you generate it in the %post script, thus ensuring that every
install has a unique file.
But I do not like the way you clean up the file in the %postun scriptlet.
The way it is handled right now is that there's a file in /etc/ that does not
belong to any package.
# rpm -ql postsrsd | grep -F postsrsd.secret
# rpm -qf /etc/postsrsd.secret
file /etc/postsrsd.secret is not owned by any package
#
I would expect the postsrsd package to own this file.
You can achieve that by adding the filepath with the %ghost tag to the spec
file in the %files section.
http://ftp.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html has some
details.
The rm -f command can be removed then.
Please fix that before uploading the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
