https://bugzilla.redhat.com/show_bug.cgi?id=1585565

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #5 from Robert-André Mauchin <zebo...@gmail.com> ---
 - Please use your Fedora People space instead of Google to host your files,
see
https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org?rd=Fedorapeople.org#Accessing_Your_fedorapeople.org_Space

 - Not needed:

%defattr(-,root,root,-)

 - Install the doc but without COPYING:

%doc AUTHORS NEWS THANKS README ChangeLog
%license COPYING

 - %{_datadir}/metainfo → %{_metainfodir}  (F28+ only)

 - Remove:

update-desktop-database &> /dev/null ||:

 - This shouldn't be necessary as you already installing the man page with 644
perm:

chmod -x %{buildroot}%{_mandir}/man1/shaman.1

 - Not needed:

Requires(post): info
Requires(post): desktop-file-utils
Requires(preun): info
Requires(post): desktop-file-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GTVGMSJABZAKQ64HWJLXDUHNWC53WO3Y/

Reply via email to