https://bugzilla.redhat.com/show_bug.cgi?id=1585565



--- Comment #15 from Mohammed Isam <mohammed_isam1...@yahoo.com> ---
(In reply to Robert-André Mauchin from comment #14)

>    Your package should be noarch.
> 
> BuildArch: noarch

Fixed.

>  - Your .desktop file is linking to /bin/shaman: it should be
> /usr/bin/shaman:

Fixed.

>  - The THANKS file is empty, don't install it with %doc

Fixed.

>  - Remove the comment %global debug_package %{nil} and/or escape the macros
> which are in comment by doubling the %:
> 
> * Tue Jun 26 2018 Mohammed Isam <mohammed_isam1...@yahoo.com> 1.0-5
> - Fixed the spec file (added %%jpackage_script BuildRequires clause)

Removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YK2J332MPUAUGY5CKCMBBGGOGHTAWVXI/

Reply via email to