Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=651227 Thomas Spura <toms...@fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Thomas Spura <toms...@fedoraproject.org> 2010-11-12 09:34:07 EST --- (In reply to comment #6) > (In reply to comment #5) > > - Where do you have the sources from? > > You need to write the commands down, how you generated that tar ball, when > > using git or somthing (don't find the guideline link atm...) > > > It's just a temporary thing. SleekXMPP will be hosted on pypi after the final > release. The current problem is that github generates a temporary URL only > when > browsing the download page. So I hosted it myself, but in the futur it should > be OK directly from upstream. > Anyway, fixed in the spec. There is a regular script running, which checks, if all packages build with the upstream sources. In this case your prackage would pass, because you publish it manually on fedorapeople. Please delete that link, so the package would fail in the sources test. -> Source0: sleekxmpp-%{version}-Beta2-0.tar.gz > > - Please add acomment, that you didn't add python3-dns yet to Requires > > > Done not done ;) - License is ok - R: seem ok When you fix the source-problem from above, this package is approved. _________________________________________________ APPROVED _________________________________________________ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
