Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651227

--- Comment #8 from Florent Le Coz <lo...@louiz.org> 2010-11-15 06:00:46 EST ---
(In reply to comment #7)
> There is a regular script running, which checks, if all packages build with 
> the
> upstream sources. In this case your prackage would pass, because you publish 
> it
> manually on fedorapeople. Please delete that link, so the package would fail 
> in
> the sources test.
> 
> -> Source0: sleekxmpp-%{version}-Beta2-0.tar.gz
> 
Ok, done. Now rpmlint complains (two warnings), but I suppose it's the expected
behaviour.

> > > - Please add acomment, that you didn't add python3-dns yet to Requires
> > > 
> > Done
> 
> not done ;)
> 
Well, yes, it's done in the   %package -n python3-sleekxmpp   section.

> - License is ok
> - R: seem ok
> 
> When you fix the source-problem from above, this package is approved.
> 
> _________________________________________________
> 
> 
> APPROVED
> 
> _________________________________________________

Thanks
So here is the fixed version:

Spec URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp.spec
SRPM URL:
http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp-1.0-0.5.beta2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to