https://bugzilla.redhat.com/show_bug.cgi?id=1859207
--- Comment #2 from Zdenek Dohnal <zdoh...@redhat.com> --- (In reply to Artur Iwicki from comment #1) > >Source: > >https://github.com/alexpevzner/%{name}/archive/%{version}.tar.gz > 1. You can use %{URL} here to make the line shorter. Fixed for convenience. > 2. GitHub allows you to do "archive/%{version}/%{name}-%{version}.tar.gz" - > you can get a file containing the repo name, not just the version. I'm not upstream maintainer, upstream's using just git tags, so I don't have this option - IIRC it isn't mandatory and can be worked around by '-n' during autosetup. > > >%autosetup -n %{name}-%{version} -S git > The "-S git" part is not needed. Package builds fine without it and the > resulting executables/libraries are the same. IMO maintainer's experience is better - I'm kind of tired of typing 'git init && git add .' every time I go to source directory for applying a patch (sometimes git is more friendly than backuping a file+modify+gendiff for applying patches). '-S git' creates git repo in source dir by default. > > >%make_build CFLAGS="%{optflags}" CPPFLAGS="%{optflags}" > >LDFLAGS="%{build_ldflags}" > You can call the %set_build_flags macro before %make_build, that should > setup up CFLAGS/LDFLAGS. Thanks for the tip! I use %set_build_flags now, hardening flags (checked via annocheck) didn't change. > > >%{_mandir}/man1/airscan-discover.1.gz > >%{_mandir}/man5/sane-airscan.5.gz > Do not assume that man pages will be gzipped. Use a wildcard that can match > any compression method (including no compression at all). > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Ok, I'm not fond of using wildcards in %files, because it can lead into unexpected shipped files, but if FPG demands, I'll change it. The links were updated accordingly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
