https://bugzilla.redhat.com/show_bug.cgi?id=2059313
Garry T. Williams <gtwilli...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gtwilli...@gmail.com
--- Comment #1 from Garry T. Williams <gtwilli...@gmail.com> ---
I am not a packager yet, but I have a package that has been approved (bz
2040118) and I am looking for a sponsor.
I have no experience packaging python applications, but I do have two comments
about your spec file:
URL: https://github.com/simple-salesforce/simple-salesforce
Source0:
https://github.com/simple-salesforce/simple-salesforce/archive/%{commit}/simple-salesforce-%{shortcommit}.tar.gz
is better written as
URL: https://github.com/%{pypi_name}/%{pypi_name}
Source0: %{url}/archive/%{commit}/%{pypi_name}-%{shortcommit}.tar.gz
And you can avoid duplicating text using:
%global _description %{expand:
Simple Salesforce is a basic Salesforce.com REST API client built for Python.
The goal is to provide a very low-level interface to the REST Resource and APEX
API, returning a dictionary of the API JSON response.}
...
%description
%{_description}
...
%description -n python3-%{pypi_name}
%{_description}
Hope this helps.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2059313
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
