https://bugzilla.redhat.com/show_bug.cgi?id=2057302
--- Comment #3 from marlin.so...@laro.se ---
Hi, thank you for taking a look at this.
> Is it worth enabling GUI support, native bt support and python3 support?
Yes, thanks for catching that. Updated in spec.
> Can you try and use system library versions of jansson ( BuildRequire:
> jansson-devel ) Lua ( BuildRequire: lua-devel ), and Whereami (BuildRequires:
> whereami).
lua5.2 is a hard requirement right now so using internal library.
I couldn't find a devel package for whereami (usually libwhereami), so using
internal.
> I think the correct lincese tag here is not 'GPL-3.0' but 'GPLv3+'
Updated in spec.
> you should own /usr/share/proxmark3 directory. either a %dir in files or
remove the /* at the end so it includes the directory
Updated in spec.
> Why the:
%global debug_package %{nil}
%define __strip /bin/true
There are some device firmware files built by arm-none-eabi-gcc which don't
include build-id and they fail during stripping. Please let me know if there's
a better/preferred way of doing this, I wasn't sure.
> Is it worth running the tests in %check? If they don't need internet it might
> be worth
enabling them.
There are some checks which require packages/package version not available:
namely openssl backwards support for secp128r1
New spec:
https://raw.githubusercontent.com/s00se/proxmark3/v4.14831.1/packaging/fedora/proxmark3.spec
New COPR builds:
https://copr.fedorainfracloud.org/coprs/s00se/proxmark3/build/3707171/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2057302
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
