Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=659082 --- Comment #5 from Orcan Ogetbil <oget.fed...@gmail.com> 2011-01-28 10:46:58 EST --- Thanks for the update. It is now in much better shape. I still have a few questions though: ? Do we really need these: %{?!pybasever:%{expand:%%define pybasever %(%{__python} -c "import sys ; print sys.version[:3]")}} %if "%{pybasever}" == "2.3" Requires: python-abi = 2.3 %endif Python-2.3 is a bit too old. I don't even remember what Fedora version came with it. This is not a blocker but I am curious why you have this in the specfile. ! php_extdir doesn't match the guideline http://fedoraproject.org/wiki/Packaging:PHP#PECL_Modules ? How about instead of %attr(664,root,root) %doc perl/example.pl just %doc perl/example.pl ? Why is this file a ghost? %ghost %{python_sitearch}/RDF.pyo ! I am still not sure how to handle the common %doc files. I will send an email to the packaging list. In case we need a common package, we will probably need a versioned requires, such as Requires: redland-bindings = %{version}-%{release} in the subpackages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
