https://bugzilla.redhat.com/show_bug.cgi?id=2222367



--- Comment #6 from Ben Beasley <c...@musicinmybrain.net> ---
(In reply to Mattia Verga from comment #3)
> The LICENSES.dependencies file is already added to the package by python
> macros in the same dir as the main license file. Is there a way to know it
> is correctly labeled with %license?

$ rpm -qL -p
/var/lib/mock/fedora-rawhide-x86_64/result/python3-rpds-py-0.8.10-1.fc39.x86_64.rpm
[no output]

Thus, there are no files marked with %license, not even the main LICENSE file.
You’ll have to handle both license files manually.

The ability of pyproject-rpm-macros/%{pyproject_files} to handle license files
automatically depends on the build backend marking them in the wheel metadata
according to draft PEP 639. For setuptools, files that match the patterns
{'LICEN[CS]E*', 'COPYING*', 'NOTICE*', 'AUTHORS*'} are considered license
files. For hatchling, license files are generally included (but not with the
version of hatchling packaged in EPEL9); I forget the exact conditions for it
to happen, though. For flit_core, poetry-core, and apparently maturin, it
doesn’t ever happen.

It’s *always* worth checking with “rpm -qL -p” at package review time and any
time there are major changes to the upstream build system.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2222367

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202222367%23c6
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to