https://bugzilla.redhat.com/show_bug.cgi?id=2218606
--- Comment #10 from Link Dupont <l...@sub-pop.net> --- (In reply to Mikel Olasagasti Uranga from comment #9) > Sorry, I just realized a minor issue: > > > %global goipath github.com/golang-migrate/migrate > > The correct path is github.com/golang-migrate/migrate/v4 > > https://github.com/golang-migrate/migrate/blob/master/go.mod#L1 Good catch. Corrected. I noticed since setting the %goname to 'migrate', the resulting SRPM is named 'migrate'. Would it make sense to follow that convention and name the dist-git repo and spec file 'migrate' as well? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c10 _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
