https://bugzilla.redhat.com/show_bug.cgi?id=2218606
--- Comment #19 from Link Dupont <l...@sub-pop.net> --- (In reply to Mikel Olasagasti Uranga from comment #18) > For `golang(github.com/google/go-github/v39/github)` you can try to replace > to latest as done at golang-cloud-google.spec or gopass.spec. If it doesn't > work you can either remove that backend, create package > `golang-github-google-go-github-39` or patch the app. Fixed. This was nicer too. It allowed me to include the github source driver. > For golang(github.com/dhui/dktest) removing the files, test files, should be > the easiet. Fixed. > > golang-github-migrate-4-devel.noarch: E: zero-length > > /usr/share/gocode/src/github.com/golang-migrate/migrate/v4/database/crate/README.md > > golang-github-migrate-4-devel.noarch: E: zero-length > > /usr/share/gocode/src/github.com/golang-migrate/migrate/v4/database/shell/README.md > > Do not include those files Fixed. I also noticed a couple issues with the way the 'migrate' program was built. It requires buildtags explicitly; otherwise the driver is not included in the resulting binary. I also added an LDFLAG to set the internal version string to %version. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c19 _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
