Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674180 --- Comment #2 from Golo Fuchert <packa...@golotop.de> 2011-02-06 18:09:35 EST --- Here are some initial comments/questions before the review. - I think the homepage in your spec file is wrong. It seems that there was a rewrite of Knights and your sources are provided by http://opendesktop.org/content/show.php?content=122046 - You might want to consider to use macros like %{name} in the Source0 tag, too. This will save you some work later on! - The headers of the source files state: "GNU General Public License [...]; either version 2 of the License or (at your option) version 3 or any later version accepted by the membership of KDE e.V." so GPLv3+ is somehow an oversimplification, isn't it? - Concerning Licensing: The source file contains no file containing the license text (e.g. COPYING), it is best to ask upstream to change this. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Why are you not using make %{?_smp_mflags} ? Did I miss something? Beside of that I think the package is ready for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
